On Sun Dec 22, 2024 at 5:23 PM EET, Jarkko Sakkinen wrote: > On Sun Dec 22, 2024 at 5:00 PM EET, James Bottomley wrote: > > If event logs grow to greater than KMALLOC_MAX_SIZE then absolutely it > > makes sense to map them instead of copying them. But we'd have to do > > that for all event log locators: ACPI, EFI and OF, because event log > > size should be independent of the mechanism used to locate it. So, > > even as a long term fix (assuming we think there's a possibility of > > logs expanding by 50x), this patch doesn't do the right thing because > > it only maps ACPI logs. > > Because we have a test target only on ACPI where this happens fix > should still fix only ACPI. It's not hard to reiterate this but > precursory iteration is a bad idea. Also, "event log size should be independent of the mechanism used to locate it" is a sentence that is sky high too abstract to say much. I don't know what it means to be frank. BR, Jarkko
