On Thu, 2024-11-14 at 00:56 +0100, Christoph Anton Mitterer wrote: > On Wed, 2024-11-13 at 07:47 -0800, James Bottomley wrote: > > That could be more significant, especially with this in the log: > > > > > Nov 13 12:33:06 heisenberg kernel: tpm tpm0: NULL Seed name > > > comparison failed > > > Nov 13 12:33:16 heisenberg kernel: tpm tpm0: NULL Seed name > > > comparison failed > > > Nov 13 12:33:26 heisenberg kernel: tpm tpm0: NULL Seed name > > > comparison failed > > > > I think we might have to expect the NULL name to change on actual > > hibernation because unlike suspend to ram it does power off the > > TPM. > > > > However, the code that causes the above message was also in 6.10 > > ... > > are you sure kernels 6.10 and beyond hibernate without producing > > this > > message? > > Quite sure. At least the "flooding" wasn't the case, and `grep`ing > some > older kernel logs (these should all be 6.11.5) I get: > $ zgrep tpm /var/log/kern.log.2.xz > 2024-10-29T21:03:39.499295+01:00 heisenberg kernel: tpm_tis > NTC0702:00: Ignoring error -5 while suspending > 2024-10-30T14:23:34.460371+01:00 heisenberg kernel: tpm_tis > NTC0702:00: Ignoring error -5 while suspending > 2024-10-30T17:50:53.559651+01:00 heisenberg kernel: tpm_tis > NTC0702:00: 2.0 TPM (device-id 0xFC, rev-id 1) > 2024-10-31T14:28:10.449727+01:00 heisenberg kernel: tpm tpm0: NULL > key integrity failure! > 2024-10-31T14:28:10.529662+01:00 heisenberg kernel: tpm tpm0: NULL > Seed name comparison failed > 2024-10-31T14:28:10.529673+01:00 heisenberg kernel: tpm tpm0: NULL > name has changed, disabling TPM due to interference > 2024-10-31T19:52:23.385845+01:00 heisenberg kernel: tpm_tis > NTC0702:00: Ignoring error -5 while suspending > 2024-11-01T06:55:20.138812+01:00 heisenberg kernel: tpm_tis > NTC0702:00: Ignoring error -5 while suspending > 2024-11-01T15:41:22.428940+01:00 heisenberg kernel: tpm_tis > NTC0702:00: Ignoring error -5 while suspending > 2024-11-01T18:33:47.141633+01:00 heisenberg kernel: tpm_tis > NTC0702:00: Ignoring error -5 while suspending > 2024-11-01T22:28:13.469085+01:00 heisenberg kernel: tpm_tis > NTC0702:00: Ignoring error -5 while suspending > 2024-11-02T06:12:26.424367+01:00 heisenberg kernel: tpm_tis > NTC0702:00: Ignoring error -5 while suspending > > But this is probably anyway obsolete as Jarkko seems to have found > the issue :-) Getting the TPM messages to quiet by disabling the chip fixes the message spew, but it doesn't get you a working TPM chip back on resume. I'll take a look at the hibernation path and see if I can see a hook we can use to bring the TPM back. Regards, James
