On Mon, Sep 23, 2024 at 10:52:49AM +0300, Jarkko Sakkinen wrote:
> On Mon Sep 23, 2024 at 9:05 AM EEST, Herbert Xu wrote:
> > Dear TPM maintainers:
>
> There's really only just me (for past 10 years). Maybe that should be
> updatred.
:)
> > BUG_ON(!mutex_is_locked(&reading_mutex));
> > - if (rng->read)
> > - return rng->read(rng, (void *)buffer, size, wait);
> > + if (rng->read) {
> > + int err;
> > +
> > + err = rng->read(rng, buffer, size, wait);
> > + if (WARN_ON_ONCE(err > 0 && err > size))
>
> Are you sure you want to use WARN_ON_ONCE here instead of
> pr_warn_once()? I.e. is it worth of taking down the whole
> kernel?
Absolutely. If this triggers it's a serious kernel bug and we
should gather as much information as possible. pr_warn_once is
not the same thing as WARN_ON_ONCE in terms of what it prints.
If people want to turn WARNs into BUGs, then they've only got
themselves to blame when the kernel goes down. On the other
hand perhaps they *do* want this to panic and we should hand
it to them.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
