Re: [PATCH 07/13] LSM: Use lsmblob in security_current_getsecid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Casey,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pcmoore-selinux/next]
[also build test WARNING on zohar-integrity/next-integrity linus/master pcmoore-audit/next v6.11-rc5 next-20240826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Casey-Schaufler/LSM-Add-the-lsmblob-data-structure/20240826-170520
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next
patch link:    https://lore.kernel.org/r/20240825190048.13289-8-casey%40schaufler-ca.com
patch subject: [PATCH 07/13] LSM: Use lsmblob in security_current_getsecid
config: arc-randconfig-001-20240827 (https://download.01.org/0day-ci/archive/20240827/202408270512.9cZ78Eog-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408270512.9cZ78Eog-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408270512.9cZ78Eog-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> security/smack/smack_lsm.c:2265: warning: Function parameter or struct member 'blob' not described in 'smack_task_getlsmblob_obj'
>> security/smack/smack_lsm.c:2265: warning: Excess function parameter 'secid' description in 'smack_task_getlsmblob_obj'


vim +2265 security/smack/smack_lsm.c

1fb057dcde11b35 Paul Moore      2021-02-19  2255  
1fb057dcde11b35 Paul Moore      2021-02-19  2256  /**
fd64f9693f6c226 Casey Schaufler 2024-08-25  2257   * smack_task_getlsmblob_obj - get the objective data of the task
1fb057dcde11b35 Paul Moore      2021-02-19  2258   * @p: the task
1fb057dcde11b35 Paul Moore      2021-02-19  2259   * @secid: where to put the result
1fb057dcde11b35 Paul Moore      2021-02-19  2260   *
1fb057dcde11b35 Paul Moore      2021-02-19  2261   * Sets the secid to contain a u32 version of the task's objective smack label.
e114e473771c848 Casey Schaufler 2008-02-04  2262   */
fd64f9693f6c226 Casey Schaufler 2024-08-25  2263  static void smack_task_getlsmblob_obj(struct task_struct *p,
fd64f9693f6c226 Casey Schaufler 2024-08-25  2264  				      struct lsmblob *blob)
e114e473771c848 Casey Schaufler 2008-02-04 @2265  {
1fb057dcde11b35 Paul Moore      2021-02-19  2266  	struct smack_known *skp = smk_of_task_struct_obj(p);
2f823ff8bec03a1 Casey Schaufler 2013-05-22  2267  
fd64f9693f6c226 Casey Schaufler 2024-08-25  2268  	blob->smack.skp = skp;
fd64f9693f6c226 Casey Schaufler 2024-08-25  2269  	/* scaffolding */
fd64f9693f6c226 Casey Schaufler 2024-08-25  2270  	blob->scaffold.secid = skp->smk_secid;
e114e473771c848 Casey Schaufler 2008-02-04  2271  }
e114e473771c848 Casey Schaufler 2008-02-04  2272  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux