On Fri, 2024-06-28 at 10:54 +1000, Michael Ellerman wrote:
> Stefan Berger <stefanb@xxxxxxxxxxxxx> writes:
> > Fix the following type of error message caused by a missing call to
> > tpm2_sessions_init() in the IBM vTPM driver:
> >
> > [ 2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error
> > 0x01C4
> > [ 2.987140] ima: Error Communicating to TPM chip, result: -14
> >
> > Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation")
> > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> > ---
> > drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c
> > b/drivers/char/tpm/tpm_ibmvtpm.c
> > index d3989b257f42..1e5b107d1f3b 100644
> > --- a/drivers/char/tpm/tpm_ibmvtpm.c
> > +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> > @@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev
> > *vio_dev,
> > rc = tpm2_get_cc_attrs_tbl(chip);
> > if (rc)
> > goto init_irq_cleanup;
> > +
> > + rc = tpm2_sessions_init(chip);
> > + if (rc)
> > + goto init_irq_cleanup;
> > }
> >
> > return tpm_chip_register(chip);
>
> #regzbot ^introduced: d2add27cf2b8
Could you please test out the patch I proposed for this:
https://lore.kernel.org/linux-integrity/1302b413a2d7bf3b275133e7fdb04b44bfe2d5e3.camel@xxxxxxxxxxxxxxxxxxxxx/
Because it's not just tmp_ibmvtpm that doesn't call autostart. From
inspection xen-tpmfront, tmp_nsc, tpm_infineon and tpm_atmel also
don't, so it would be better to fix this for everyone rather than just
for you and have to do a separate fix for each of them.
James
