[removing stable@xxxxxxxxxxxxxxx from cc -- they're only interested in your patch once it's in Linus' tree] On Fri, Jun 21, 2024 at 10:50:45AM +0100, Vitor Soares wrote: > "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not > allowing module autoloading and leading to the following message: > > "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p" [...] > Fix this by adding the corresponding "attpm20p" spi_device_id entry. > > Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p") > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Vitor Soares <vitor.soares@xxxxxxxxxxx> Reviewed-by: Lukas Wunner <lukas@xxxxxxxxx> The old problem that spi modules aren't auto-loaded based on MODULE_DEVICE_TABLE(of, ...), but only on MODULE_DEVICE_TABLE(spi, ...): https://lore.kernel.org/all/20170811081429.GA9957@xxxxxxxxx/ Completely forgot that this is still a problem after all these years. :( Thanks, Lukas