On Sun May 26, 2024 at 8:42 AM EEST, Paul Menzel wrote: > Dear Jarkko, > > > Thank you for your patch. > > Am 25.05.24 um 17:44 schrieb Jarkko Sakkinen: > > With only single call site, this no sense, and it actually slipped out > > this *makes* no sense? Thanks for the remark :-) > > > of the radar during the review. Open code and document the action > > directly to the site, to make it more readable. > > […] > > > Kind regards, > > Paul In order not to have to recycle this, does this now make sense to you: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=b6b88cde77e7c30ab8f534d723ad9c4ec15b7753 Unless actual critical fixes for hmac, probably will save this to v6.11 but with some "real" fixes I'll piggy pack it to rcX. BR, Jarkko