Re: [PATCH v7 13/21] tpm: Add HMAC session start and end functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2024-02-23 at 19:02 +0200, Jarkko Sakkinen wrote:
> On Tue Feb 13, 2024 at 7:13 PM EET, James Bottomley wrote:
[...]
> >  static int tpm2_parse_create_primary(struct tpm_chip *chip, struct
> > tpm_buf *buf,
> >                                      u32 *nullkey)
>                 
> 
> What if this was simply tpm2_create_primary?

It would cause a massive code block surrounded by an if, which would
make the function somewhat less readable.

James





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux