Re: [PATCH v6] ima: add crypto agility support for template-hash algorithm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2024-04-10 at 10:37 +0200, Enrico Bravi wrote:
> > > +static struct dentry **ascii_securityfs_measurement_lists
> > > __ro_after_init;
> > > +static struct dentry **binary_securityfs_measurement_lists
> > > __ro_after_init;
> > > +static int securityfs_measurement_list_count __ro_after_init;
> > > +
> > > +static void lookup_algo_by_dentry(int *algo_idx, enum hash_algo *algo,
> > > +                              struct seq_file *m, struct dentry
> > > **dentry_list)
> > 
> > Please rename the function without "_by_dentry". Consider naming the
> > function
> > lookup_measurement_list_algo().  Instead of dentry_list, consider naming the
> > variable measurement_lists or just lists.
> What do you think of lookup_template_data_hash_algo()?

Sounds good.

Mimi





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux