On Tue, Apr 2, 2024 at 6:42 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Tue, Apr 02, 2024 at 05:36:30PM -0400, Paul Moore wrote: > > > > 1) location of that hook is wrong. It's really "how do we catch > > > file creation that does not come through open() - yes, you can use > > > mknod(2) for that". It should've been after the call of vfs_create(), > > > not the entire switch. LSM folks have a disturbing fondness of inserting > > > hooks in various places, but IMO this one has no business being where > > > they'd placed it. > > > > I know it's everyone's favorite hobby to bash the LSM and LSM devs, > > but it's important to note that we don't add hooks without working > > with the associated subsystem devs to get approval. In the cases > > where we don't get an explicit ACK, there is an on-list approval, or > > several ignored on-list attempts over weeks/months/years. We want to > > be good neighbors. > > > > Roberto's original patch which converted from the IMA/EVM hook to the > > LSM hook was ACK'd by the VFS folks. > > > > Regardless, Roberto if it isn't obvious by now, just move the hook > > back to where it was prior to v6.9-rc1. > > The root cause is in the too vague documentation - it's very easy to > misread as "->mknod() must call d_instantiate()", so the authors of > that patchset and reviewers of the same had missed the subtlety > involved. No arguments about that. > > Unkind comments about the LSM folks' tendency to shove hooks in > places where they make no sense had been brought by many things, > the most recent instance being this: > However, I thought, since we were promoting it as an LSM hook, > we should be as generic possible, and support more usages than > what was needed for IMA. > (https://lore.kernel.org/all/3441a4a1140944f5b418b70f557bca72@xxxxxxxxxx/) > > I'm not blaming Roberto - that really seems to be the general attitude > around LSM; I've seen a _lot_ of "it doesn't matter if it makes any sense, > somebody might figure out some use for the data we have at that point in > control flow, eventually if not now" kind of responses over the years. > IME asking what this or that hook is for and what it expects from the objects > passed to it gets treated as invalid question. It's rather common for subsystems to push back on the number LSM hooks, which ends up resulting in patterns where LSM hooks are placed in as wide a scope as possible both to satisfy the requirements of the individual subsystems as well as the LSM's requirements on coverage. Clearly documenting hooks, their inputs, return values, constraints, etc. is important and we need to have those discussions as part of the hook. This is a big part of why we CC the subsystems when adding new hooks and why I make sure we get an ACK or some other approval for a subsystem maintainer before we merge a new hook. Is the system perfect, no, clearly not, but I don't believe it is for a lack of trying or any ill intent on the part of the LSM devs. We recently restored the LSM hook comment blocks in security/security.c (long story), I would gladly welcome any comments/edits/suggestions you, or anyone else may have, about the docs there - I will be the first to admit those docs have rotted quite a bit (once again, long story). If you have corrections, notes, or constraints that should be added please let me know and/or send patches. Similarly, if you're aware of any hooks which are ill advised and/or poorly placed, let us know so we can work together to fix things. I'm serious Al. These aren't just words in an email. I realize you don't have a lot of free cycles, but if you do have feedback on any of those things above, I'm listening. I *really* want to see better collaboration between various subsystems and the LSMs; that's part of why I get annoyed with LSM bashing, leaving the LSM devs out of security/LSM related threads, etc. it only helps keep the divide up between the groups which is bad for all of us. -- paul-moore.com
