On Tue Mar 19, 2024 at 11:38 PM EET, Jarkko Sakkinen wrote: > On Tue Mar 19, 2024 at 9:57 PM EET, Jarkko Sakkinen wrote: > > On Wed Mar 13, 2024 at 7:02 PM EET, Adam Alves wrote: > > > Hi Jarkko, > > > > > > Thank you very much for kindly reviewing this proposal. > > > > > > After one week without any issues with my PC hanging, it happened > > > again. It seems that the fix I am proposing is not final (it only > > > reduced the frequency since it always happened when I shutdown after > > > couple hours of power up time and now it only happened after two weeks > > > with a similar usage rate). > > > > > > I will share with you the data you requested below. > > > > Thanks I'll definitely check these in detail. > > > > Any possible bug fix (if we decide to fix anything) is tpm_crb.c > > including possible kernel command-line parameters or whatever. The > > current proposal affects all the possible pieces of TPM hardware so > > in all cases it is unacceptable. > > > > Do you have dmesg/journactl transcript? Did you try to update the > > firmware? > > OK so I do have ASUS motherboard and my TPM2 ACPI table is almost the > same match but: > > BIOS Information > Vendor: American Megatrends Inc. > Version: 2212 > Release Date: 12/13/2022 > Address: 0xF0000 > Runtime Size: 64 kB > ROM Size: 24 MB > > Where as in you dmidecode.txt: > > Handle 0x0000, DMI type 0, 26 bytes > BIOS Information > Vendor: American Megatrends Inc. > Version: 1601 > Release Date: 02/11/2022 > Address: 0xF0000 > Runtime Size: 64 kB > ROM Size: 16 MB > > So at least the BIOS version is older. Can you update BIOS and see if > that could possibly fix the issue? > > Make sure that it contains update for both BIOS and Management Engine. AND if you end up still proposing any fix please make sure that it only changes tpm_crb.c so that there is something to analyze. Sprinkled arbitrary changes are not something we can really not say much. If you don't know exactly what you are fixing and why please try to keep the fix local to the issue. But yeah, BIOS update is really the first trial here. BR, Jarkko
