Dear Paul, Thank you very much for your review, I will provide a new version with some of your suggestions. > Out of curiosity, would reboot work? Reboot works, but clearly in an error handling path by the firmware (the whole system is powered off for some seconds and then turned backed on automatically), this doesn't happen when I am rebooting from another OS. With this fix, reboot goes softly in Linux as well. > I’d use `` from Markdown. > Could you please document the TPM for completeness? Done. Will be submitted with a new version. > Is the exception useful, if a user explicitly requests to disable the > behavior? I was thinking for a case, where a newer system firmware has a > fix (and the DMI check would need to be extended). Thanks! Will submit a new version with possibility to set module param to force enable, force disable and auto. Will also include cmdline documentation on parameter. > For completeness, I’d mention/paste the new log message. Will be submitted with a new version. > Should this be backported to the stable series? That would be great, please advise me if I need to do anything to allow that. > Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx> Thank you, will include this on the next version, submitting shortly - I am currently testing. Best, Adam Alves
