On Tue Mar 5, 2024 at 5:52 PM EET, Paul Menzel wrote: > #regzbot fixed-by: d6fb14208e22c7bb6f54cb9df960bfc21e4663e3 > > Dear Jarkko, > > > Am 02.02.24 um 00:02 schrieb Jarkko Sakkinen: > > On Tue Jan 16, 2024 at 4:44 PM EET, Paul Menzel wrote: > >> #regzbot introduced: v5.15.131..v6.6.11 > > >> On a Dell OptiPlex 5055 with an AMD Ryzen, Linux always logged the error > >> tpm_tis: probe of MSFT0101:00 failed with error -1 > >> > >> but upgrading from 5.15.131 to 6.6.11, the warning below is also logged: > >> > >> ``` > >> [ 0.000000] Linux version 6.6.11.mx64.460 (root@xxxxxxxxxxxxxxxxxxxxxxxxx) (gcc (GCC) 12.2.0, GNU ld (GNU Binutils) 2.41) #1 SMP PREEMPT_DYNAMIC Thu Jan 11 16:15:43 CET 2024 > >> [ 0.000000] Command line: BOOT_IMAGE=/boot/bzImage-6.6.11.mx64.460 root=LABEL=root ro crashkernel=64G-:256M console=ttyS0,115200n8 console=tty0 init=/bin/systemd audit=0 random.trust_cpu=on systemd.unified_cgroup_hierarchy > >> […] > >> [ 0.000000] DMI: Dell Inc. OptiPlex 5055 Ryzen CPU/0P03DX, BIOS 1.1.20 05/31/2019 > >> […] > >> [ 12.092264] WARNING: CPU: 6 PID: 265 at kernel/workqueue.c:3397 __flush_work.isra.0+0x29f/0x2c0 > >> [ 12.103259] Modules linked in: snd_hda_intel(+) tg3(+) kvm(+) snd_intel_dspcfg snd_hda_codec snd_hda_core snd_pcm snd_timer libphy drm_ttm_helper ttm snd video k10temp soundcore i2c_piix4 irqbypass tpm_tis(+) tpm_tis_core efi_pstore tpm wmi_bmof rng_core wmi crc32c_intel pstore acpi_cpufreq nfsd auth_rpcgss oid_registry nfs_acl lockd grace sunrpc efivarfs ip_tables x_tables ipv6 autofs4 > >> [ 12.143539] CPU: 6 PID: 265 Comm: systemd-udevd Not tainted 6.6.11.mx64.460 #1 > >> [ 12.152698] Hardware name: Dell Inc. OptiPlex 5055 Ryzen CPU/0P03DX, BIOS 1.1.20 05/31/2019 > >> [ 12.162512] RIP: 0010:__flush_work.isra.0+0x29f/0x2c0 > >> [ 12.168674] Code: 8b 04 25 80 cf 02 00 48 89 44 24 40 48 8b 53 40 8b 43 30 e9 b3 fe ff ff 40 30 f6 4c 8b 36 e9 f2 fd ff ff 0f 0b e9 3b ff ff ff <0f> 0b e9 34 ff ff ff 0f 0b e9 d8 fe ff ff 0f 0b e9 a9 fe ff ff e8 > >> [ 12.188375] RSP: 0018:ffffc90000ab7a10 EFLAGS: 00010246 > >> [ 12.194699] RAX: 0000000000000000 RBX: ffff888108f79b28 RCX: 0000000000000000 > >> [ 12.202894] RDX: ffffc90000ab7a10 RSI: ffffc90000b10008 RDI: ffffc90000ab7a58 > >> [ 12.211107] RBP: ffff888108f79b68 R08: 0000000000000002 R09: 0000000000000000 > >> [ 12.219305] R10: 0000000000000001 R11: 0000000000000000 R12: 0000000000000001 > >> [ 12.227499] R13: ffff888108f79b38 R14: 00000000ffffffff R15: 0000000000fe1050 > >> [ 12.235706] FS: 00007f2cf22c2800(0000) GS:ffff88840eb80000(0000) knlGS:0000000000000000 > >> [ 12.244871] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > >> [ 12.251670] CR2: 00000000006878e8 CR3: 000000010ca66000 CR4: 00000000003506e0 > >> [ 12.259901] Call Trace: > >> [ 12.263395] <TASK> > >> [ 12.266521] ? __warn+0x81/0x140 > >> [ 12.270776] ? __flush_work.isra.0+0x29f/0x2c0 > >> [ 12.276235] ? report_bug+0x171/0x1a0 > >> [ 12.280803] ? handle_bug+0x3c/0x70 > >> [ 12.285352] ? exc_invalid_op+0x17/0x70 > >> [ 12.290203] ? asm_exc_invalid_op+0x1a/0x20 > >> [ 12.295397] ? __flush_work.isra.0+0x29f/0x2c0 > >> [ 12.300807] tpm_tis_remove+0xaa/0x100 [tpm_tis_core] > >> [ 12.306872] tpm_tis_core_init+0x234/0xfa0 [tpm_tis_core] > >> [ 12.313280] tpm_tis_plat_probe+0xd0/0x110 [tpm_tis] > >> [ 12.319139] platform_probe+0x44/0xa0 > >> [ 12.323796] really_probe+0xd0/0x3e0 > >> [ 12.328384] ? __pfx___driver_attach+0x10/0x10 > >> [ 12.334129] __driver_probe_device+0x80/0x160 > >> [ 12.339803] driver_probe_device+0x1f/0x90 > >> [ 12.344831] __driver_attach+0xf8/0x1c0 > >> [ 12.349568] bus_for_each_dev+0x88/0xd0 > >> [ 12.354298] bus_add_driver+0xf9/0x220 > >> [ 12.358919] driver_register+0x59/0x100 > >> [ 12.363623] ? __pfx_init_tis+0x10/0x10 [tpm_tis] > >> [ 12.369198] init_tis+0x39/0xff0 [tpm_tis] > >> [ 12.374172] ? srso_return_thunk+0x5/0x10 > >> [ 12.379044] do_one_initcall+0x66/0x240 > >> [ 12.383751] do_init_module+0x60/0x230 > >> [ 12.388357] init_module_from_file+0x86/0xc0 > >> [ 12.393483] idempotent_init_module+0x120/0x2b0 > >> [ 12.398869] __x64_sys_finit_module+0x65/0xc0 > >> [ 12.404082] do_syscall_64+0x46/0x90 > >> [ 12.408506] entry_SYSCALL_64_after_hwframe+0x6e/0xd8 > >> [ 12.414411] RIP: 0033:0x7f2cf1d1ed09 > >> [ 12.418831] Code: 08 44 89 e0 5b 41 5c c3 66 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d c7 20 0d 00 f7 d8 64 89 01 48 > >> [ 12.438506] RSP: 002b:00007ffc335d02f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 > >> [ 12.446965] RAX: ffffffffffffffda RBX: 0000000000674390 RCX: 00007f2cf1d1ed09 > >> [ 12.454993] RDX: 0000000000000000 RSI: 00007f2cf1a0f54b RDI: 0000000000000010 > >> [ 12.463013] RBP: 00007f2cf1a0f54b R08: 0000000000000000 R09: 0000000000000002 > >> [ 12.471025] R10: 0000000000000010 R11: 0000000000000246 R12: 0000000000000000 > >> [ 12.479059] R13: 00000000007700f0 R14: 0000000000020000 R15: 0000000000679d90 > >> [ 12.487092] </TASK> > >> [ 12.490162] ---[ end trace 0000000000000000 ]--- > >> [ 12.498048] tpm_tis: probe of MSFT0101:00 failed with error -1 > >> ``` > >> > >> ``` > >> $ scripts/decodecode < /scratch/tmp/linux-6.6.11-schokokeks.txt > >> [ 12.418831] Code: 08 44 89 e0 5b 41 5c c3 66 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d c7 20 0d 00 f7 d8 64 89 01 48 > >> All code > >> ======== > >> 0: 08 44 89 e0 or %al,-0x20(%rcx,%rcx,4) > >> 4: 5b pop %rbx > >> 5: 41 5c pop %r12 > >> 7: c3 ret > >> 8: 66 0f 1f 84 00 00 00 nopw 0x0(%rax,%rax,1) > >> f: 00 00 > >> 11: 48 89 f8 mov %rdi,%rax > >> 14: 48 89 f7 mov %rsi,%rdi > >> 17: 48 89 d6 mov %rdx,%rsi > >> 1a: 48 89 ca mov %rcx,%rdx > >> 1d: 4d 89 c2 mov %r8,%r10 > >> 20: 4d 89 c8 mov %r9,%r8 > >> 23: 4c 8b 4c 24 08 mov 0x8(%rsp),%r9 > >> 28: 0f 05 syscall > >> 2a:* 48 3d 01 f0 ff ff cmp $0xfffffffffffff001,%rax <-- trapping instruction > > > > There's something odd in this disassembly given the "syscall" opcode. > > > >> 30: 73 01 jae 0x33 > >> 32: c3 ret > >> 33: 48 8b 0d c7 20 0d 00 mov 0xd20c7(%rip),%rcx # 0xd2101 > >> 3a: f7 d8 neg %eax > >> 3c: 64 89 01 mov %eax,%fs:(%rcx) > >> 3f: 48 rex.W > >> > >> Code starting with the faulting instruction > >> =========================================== > >> 0: 48 3d 01 f0 ff ff cmp $0xfffffffffffff001,%rax > >> 6: 73 01 jae 0x9 > >> 8: c3 ret > >> 9: 48 8b 0d c7 20 0d 00 mov 0xd20c7(%rip),%rcx # 0xd20d7 > >> 10: f7 d8 neg %eax > >> 12: 64 89 01 mov %eax,%fs:(%rcx) > >> 15: 48 rex.W > >> ``` > >> > >> Please find all the Linux messages attached. Bisecting is unfortunately > >> not easily doable. > > > I reported a workqueue flush issue while ago but had forgotten it: > > > > https://lore.kernel.org/all/CX32RFOMJUQ0.3R4YCL9MDCB96@xxxxxxxxxx/f > > > > However, Lino sent a fix for it: > > > > https://lore.kernel.org/linux-integrity/20240201113646.31734-1-l.sanfilippo@xxxxxxxxxx/ > > > > Would be useful to know if that is the same wq issue also here. > > Yes, commit d6fb14208e22 (tpm,tpm_tis: Avoid warning splat at shutdown) > on top of Linux 6.8-rc7+ (also a unrelated USB patch) fixed it on the > Dell OptiPlex 5055. OK, good to hear and thank you for reporting this! BR, Jarkko
