On Fri, 2024-02-09 at 15:00 -0800, Randy Dunlap wrote: > Hi-- > > On 2/9/24 06:09, Roberto Sassu wrote: > > diff --git a/security/digest_cache/Kconfig b/security/digest_cache/Kconfig > > new file mode 100644 > > index 000000000000..0c47d5151f07 > > --- /dev/null > > +++ b/security/digest_cache/Kconfig > > @@ -0,0 +1,17 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +config SECURITY_DIGEST_CACHE > > + bool "Digest_cache LSM" > > + default n > > + help > > + This option enables an LSM maintaining a cache of digests > > + (e.g. of file content or metadata). > > + > > + This LSM can support other kernel components in making access > > + control decisions. > > + > > nit: -ESTYLE. > coding-style.rst says: > > Lines under a ``config`` definition > are indented with one tab, while help text is indented an additional two > spaces. > > > +config DIGEST_LIST_DEFAULT_PATH > > + string > > + default "/etc/digest_lists" > > + help > > + Default directory where digest_cache LSM expects to find digest > > + lists. > > Same comment for patch 03/13. > Same comment for patch 04/13. Hi Randy thanks, will apply your suggestions to the next version. Roberto