On Wed Jan 3, 2024 at 3:53 PM EET, Jarkko Sakkinen wrote:
> On Sat Dec 23, 2023 at 11:34 AM EET, Lukas Wunner wrote:
> > Commit 4f2a348aa365 ("arm64: dts: imx8mm-venice-gw73xx: add TPM device")
> > added a devicetree node for the Trusted Platform Module on certain
> > Gateworks boards.
> >
> > The commit only used the generic "tcg,tpm_tis-spi" compatible string,
> > but public documentation shows that the chip is an ATTPM20P from Atmel
> > (nowadays Microchip):
> > https://trac.gateworks.com/wiki/tpm
> >
> > Add the chip to the supported compatible strings of the TPM TIS SPI
> > driver.
> >
> > For reference, a datasheet is available at:
> > https://ww1.microchip.com/downloads/en/DeviceDoc/ATTPM20P-Trusted-Platform-Module-TPM-2.0-SPI-Interface-Summary-Data-Sheet-DS40002082A.pdf
> >
> > Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx>
> > Cc: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> > ---
> > drivers/char/tpm/tpm_tis_spi_main.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
> > index c5c3197ee29f..7d376a642807 100644
> > --- a/drivers/char/tpm/tpm_tis_spi_main.c
> > +++ b/drivers/char/tpm/tpm_tis_spi_main.c
> > @@ -327,6 +327,7 @@ static const struct spi_device_id tpm_tis_spi_id[] = {
> > MODULE_DEVICE_TABLE(spi, tpm_tis_spi_id);
> >
> > static const struct of_device_id of_tis_spi_match[] __maybe_unused = {
> > + { .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },
> > { .compatible = "st,st33htpm-spi", .data = tpm_tis_spi_probe },
> > { .compatible = "infineon,slb9670", .data = tpm_tis_spi_probe },
> > { .compatible = "tcg,tpm_tis-spi", .data = tpm_tis_spi_probe },
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxx>
Taking this back as checkpatch gives warning:
WARNING: DT compatible string "atmel,attpm20p" appears un-documented -- check ./Documentation/devicetree/bindings/
#36: FILE: drivers/char/tpm/tpm_tis_spi_main.c:330:
+ { .compatible = "atmel,attpm20p", .data = tpm_tis_spi_probe },
BR, Jarkko
