On Fri, 2023-12-01 at 08:31 -0500, Stefan Berger wrote: > Enable shellcheck for the bash scripts in the tests directory. Fix issues > on the way that are found when particular checks are enabled. In the end > all shellcheck v0.9 checks are enabled and shellcheck passes without any > issues. > > Shellcheck can be run using the following command: > > make shellcheck > > Apart from style issues two real issues are detected by SC2003 and SC2295. > > Regards, > Stefan > > v3: > - Replace read with readarray > > v2: > - Rebased on latest next-testing branch > - 1/14: Use ${var:+${var}} pattern for variables that hold multiple > arguments like "--foo bar" which would become one argument > if passed with "${var}"; fixed a build issue > - 4/14: remove $new_policy file in success and failure cases Thanks, Stefan. Other than modifying 1/14 as discussed, it looks good. The patch set is now queued in next-testing. Mimi