On Wed, 2023-11-22 at 09:33 -0500, Stefan Berger wrote: > > On 11/22/23 09:14, Mimi Zohar wrote: > > On Wed, 2023-11-22 at 08:37 -0500, Stefan Berger wrote: > >> > > >> Now you are passing valid parameters into verify_hash2(). Would it not > >> be possible to drop 4/12? > > > > Just as we can't modify the library verify_hash() definition, I don't > > think we should be modifying the verify_hash2() defintion either. > > 04/12 defines and exports the final verify_hash2() definition. > > > > The question is whether verify_hash2() can be only introduced here in > versus made available in 4/12 with a parameter that it doesn't use at > all at that point. Correct, however 6/12 "Update cmd_verify_evm to define and use a local list of public keys" calls verify_hash2(). -- thanks, Mimi
