On Sun, 2023-11-26 at 05:39 +0200, Jarkko Sakkinen wrote: > One very obvious thing to fix there is the kconfig flag: > > 1. Its meaning and purpose is not documented to the commit message. > What > is it and what is its meaning and purpose. > 2. TPM_BUS_SECURITY does not follow the naming convention of other > TPM kconfig flags, and to add, "security" is way way too abstract > word. Something like TCG_TPM_HMAC > > It should be renamed as TCG_TPM_ One question is do we still need this? Since my tree has moved ahead, I also need the HMAC code for policy on keys and the primary code for permanent parents. The only real performance concern is for PCR extension (no-one really cares about the speed of unseal or random), so a different possible way of doing this is simply to CONFIG that one operation. Regards, James
