Hi Summit, On Thu, 2023-10-05 at 19:03 +0530, Sumit Garg wrote: > Static calls invocations aren't well supported from module __init and > __exit functions, especially the static call from cleanup_trusted() led > to a crash on x86 kernel with CONFIG_DEBUG_VIRTUAL=y. Split the above paragraph into two sentences. > However, the usage of static call invocations for trusted_key_init() > and trusted_key_exit() doesn't adds any value neither from performance > point and nor there is any security benefit. don't add any value from either a performance or security perspective. > Hence switch to use indirect > function calls instead. > > Note here that although it will fix the current crash reported. But > ultimately we need fix up static calls infrastructure to either support > its future usage from module __init and __exit functions or not. The first line is a sentence fragment. Please replace the period with a comma. report, ultimately the static call call infrastructure should ... > > Reported-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx> > Closes: https://lore.kernel.org/lkml/ZRhKq6e5nF%2F4ZIV1@fedora/#t Replace "Closes" with "Link". > Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework") > Signed-off-by: Sumit Garg <sumit.garg@xxxxxxxxxx> -- thanks, Mimi
