Hi, On 11.07.23 23:50, Jarkko Sakkinen wrote: > On Tue, 2023-07-11 at 15:41 +0300, Grundik wrote: >> On Tue, 2023-07-11 at 00:29 +0300, Jarkko Sakkinen wrote: >>> On Mon, 2023-07-10 at 23:13 +0200, Christian Hesse wrote: >>> >>> >>> OK, this good to hear! I've been late with my pull request (past rc1) >>> because of kind of conflicting timing with Finnish holiday season and >>> relocating my home office. >>> >>> I'll replace v2 patches with v3 and send the PR for rc2 after that. >>> So unluck turned into luck this time :-) >>> >>> Thank you for spotting this! >> >> I want to say: this issue is NOT limited to Framework laptops. >> >> For example this MSI gen12 i5-1240P laptop also suffers from same >> problem: >> Manufacturer: Micro-Star International Co., Ltd. >> Product Name: Summit E13FlipEvo A12MT >> Version: REV:1.0 >> SKU Number: 13P3.1 >> Family: Summit >> >> So, probably just blacklisting affected models is not the best >> solution... > > It will be supplemented with > > https://lore.kernel.org/linux-integrity/CTYXI8TL7C36.2SCWH82FAZWBO@suppilovahvero/T/#me895f1920ca6983f791b58a6fa0c157161a33849 > > Together they should fairly sustainable framework. > > Lino, can you add the same fixes tag as for this. It would probably > ignore inline comments to keep the patch minimal since it is a > critical fix. Just do the renames, remove inline comments and > send v3. > > For tpm_tis_check_for_interrupt_storm(), you can could rename it > simply as tpm_tis_update_unhandle_irqs() as that it what it does > (my review did not include a suggestion for this). > > This way I think it should be fairly trivial to get a version that > can be landed. > > To put short: > 1. Do the renames as suggested, they are good enough for me. > 2. Drop inline comments, their usefulness is somewhat questionable > and they increase the diff. > 3. Generally aim for minimal diff but I think this should be good > enough if you do steps 1 and 2. > > If you don't have the time at hand, I can carefully do these cleanups > and apply the patch. If you have the time and motivation, go ahead > and send v3. >> BR, Jarkko No problem, I can do this. But note that the next version will be v4 not v3 (as v3 is the version you recently reviewed). Regards, Lino
