Adding Eric to cc.
On 7/7/23 06:55, Mimi Zohar wrote:
Hi Tushar,
On Mon, 2023-07-03 at 14:57 -0700, Tushar Sugandhi wrote:
The ima_dump_measurement_list function was designed to iterate over the
IMA measurement list and store each entry into a buffer. The buffer,
along with its size, would be returned to the caller. However, the
function is no longer required in the IMA subsystem. It previously served
to dump the measurement list during the kexec 'load' operation, but this
functionality has been replaced by an alternative approach in this patch
series.
Remove the unused ima_dump_measurement_list function from the IMA
subsystem, to ensure a cleaner and more maintainable code.
Signed-off-by: Tushar Sugandhi <tusharsu@xxxxxxxxxxxxxxxxxxx>
Have you compiled the code and tested after applying each patch?
Removing the caller before removing the code should have resulted in a
warning.
Yes, I compiled each patch separately, and I did see this warning.
But removing ima_dump_measurement_list after implementing and
calling the alternate ima_allocate_buf_at_kexec_load() and
ima_populate_buf_at_kexec_execute() felt cleaner in terms of organizing
the patches.
I can remove the definition when I deprecate the usage, if we end up
using the alternate two functions.
~Tushar
