Dear Peter, Thank you for your patch. Am 24.05.23 um 07:58 schrieb Peter Ujfalusi:
The original patch which added the quirk would apply to all AAEON machines, which might or might not be valid. The issue was discovered on UPX-i11 (TigerLake), it is not known if the i12 (AlderLake) version is affected. UP2 (ApolloLake) does not even have TMP module (no TPM drivers probing
s/TMP/TPM/
and confirmed by dmidecode).
Another nit, the official spelling of the SOC names is with a space, for example, Tiger Lake [1].
Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only. Fixes: 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11") Suggested-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx> --- Hi Jarkko, the patch is generated on top of your git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : irq-storm Regards, Peter drivers/char/tpm/tpm_tis.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 7db3593941ea..4357d4ba8f9e 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { .ident = "UPX-TGL", .matches = { DMI_MATCH(DMI_SYS_VENDOR, "AAEON"), + DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"), }, }, {}
Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx> Kind regards, Paul [1]: https://en.wikipedia.org/wiki/Tiger_Lake