Re: [PATCH 0/3] tpm: Convert to platform remove callback returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jarkko,

On Sun, Apr 23, 2023 at 09:13:57AM +0300, Jarkko Sakkinen wrote:
> On Mon, 2023-04-17 at 08:05 +0200, Uwe Kleine-König wrote:
> > Hello,
> > 
> > On Mon, Mar 20, 2023 at 09:06:04AM +0100, Uwe Kleine-König wrote:
> > > this series adapts the platform drivers below drivers/char/tpm to use the
> > > .remove_new() callback. Compared to the traditional .remove() callback
> > > .remove_new() returns no value. This is a good thing because the driver core
> > > doesn't (and cannot) cope for errors during remove. The only effect of a
> > > non-zero return value in .remove() is that the driver core emits a warning. The
> > > device is removed anyhow and an early return from .remove() usually yields a
> > > resource leak.
> > > 
> > > The drivers converted here returned zero in their remove callback, to the
> > > transformation was easy.
> > 
> > who is responsible to pick up this patch set (or express their concerns
> > when not applying it)?
> > 
> > There is (for now) no coordination necessary, the final conversion of
> > platform_driver's remove callback is still far away. So applying it via
> > it's usual repo would be great.
> 
> Please check https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/

Looking at the topmost three commits in your next branch (i.e.
0760dc1b2f58fe741bddb6a0030720dfd6ac4689) it looks fine to me.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux