On Mon, 2023-02-27 at 10:37 +0200, Jarkko Sakkinen wrote: > On Thu, Feb 16, 2023 at 03:14:04PM -0500, James Bottomley wrote: > > The TPM2 session HMAC and encryption handling code needs to save > > and restore a single volatile context for the elliptic curve > > version of the NULL seed, so export the APIs which do this for > > internal use. > > > > Signed-off-by: James Bottomley > > <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > These did not need EXPORT_SYMBOL_GPL()? No, because they're still internal to the overall tpm.ko even if it is compiled as a module. I don't think there's a huge reason to keep them as an internal only to the tpm core API, but equally without a consumer outside the core module, there's no reason to export them. James
