On Mon, Mar 20, 2023 at 11:14:15PM -0700, Harshit Mogalapalli wrote:
> Smatch reports:
> drivers/char/tpm/tpm-interface.c:470 tpm_init() error:
> 'tpm_class' dereferencing possible ERR_PTR()
>
> If class_create() returns error pointer, we are dereferencing a possible
> error pointer. Fix this by moving the dereference post error handling.
>
> Fixes: a010eb881243 ("tpm: fix up the tpm_class shutdown_pre pointer when created")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> ---
> This is based on static analysis, only compile tested.
Thanks for this, good catch, I've queued it up in my tree now as I have
the offending change that caused this.
greg k-h
