On Fri, 2023-02-10 at 16:23 -0500, Stefan Berger wrote: > > + memcpy(&flags, data, sizeof(flags)); > > conversion from bytestream to integer: I think in this case it would > be better to use > > flags = cpu_to_be64p((__u64*)data); > > so that the flags always in hypervisor/big endian format Thanks for catching this - it turns out we weren't properly testing the one flag that exists (append vs replace) in our test script, so I didn't notice this. -- Andrew Donnellan OzLabs, ADL Canberra ajd@xxxxxxxxxxxxx IBM Australia Limited
