On Wed, 2023-01-25 at 03:57 +0800, kernel test robot wrote: > Hi James, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on char-misc/char-misc-testing] > [also build test WARNING on char-misc/char-misc-next char-misc/char- > misc-linus zohar-integrity/next-integrity linus/master v6.2-rc5 next- > 20230124] > [If your patch is applied to the wrong git tree, kindly drop us a > note. > And when submitting patch, we suggest to use '--base' as documented > in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/James-Bottomley/tpm-move-buffer-handling-from-static-inlines-to-real-functions/20230125-020146 > patch link: > https://lore.kernel.org/r/20230124175516.5984-2-James.Bottomley%40HansenPartnership.com > patch subject: [PATCH v2 01/11] tpm: move buffer handling from static > inlines to real functions > config: sparc-allyesconfig > (https://download.01.org/0day-ci/archive/20230125/202301250315.ZgtsNz > Sm-lkp@xxxxxxxxx/config) > compiler: sparc64-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross > -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # > https://github.com/intel-lab-lkp/linux/commit/484b879d0bfceec899fea147a76d12f7072d9f23 > git remote add linux-review > https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review James-Bottomley/tpm-move- > buffer-handling-from-static-inlines-to-real-functions/20230125-020146 > git checkout 484b879d0bfceec899fea147a76d12f7072d9f23 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 > make.cross W=1 O=build_dir ARCH=sparc olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 > make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash > drivers/char/tpm/ > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > > > drivers/char/tpm/tpm-buf.c:46:5: warning: no previous prototype > > > for 'tpm_buf_tag' [-Wmissing-prototypes] > 46 | u16 tpm_buf_tag(struct tpm_buf *buf) > | ^~~~~~~~~~~ This looks like an initial header got missed in the code motion. However, the fact that nothing broke shows that tpm_buf_tag isn't used outside of the tpm-buf.c functions, so I think I can make it static to them. James
