On Thu, 2023-01-19 at 11:10 +1000, Nicholas Piggin wrote: > > diff --git a/arch/powerpc/include/asm/secvar.h > > b/arch/powerpc/include/asm/secvar.h > > index ebf95386d720..c8bee1834b54 100644 > > --- a/arch/powerpc/include/asm/secvar.h > > +++ b/arch/powerpc/include/asm/secvar.h > > @@ -23,6 +23,10 @@ struct secvar_operations { > > ssize_t (*format)(char *buf); > > int (*max_size)(u64 *max_size); > > const struct attribute **config_attrs; > > + > > + // NULL-terminated array of fixed variable names > > + // Only used if get_next() isn't provided > > + const char * const *var_names; > > The other way you could go is provide a sysfs_init() ops call here, > and export the add_var as a library function that backends can use. True, I think I'll keep it as is for now but I'll have a think about whether to do that in a later patch. -- Andrew Donnellan OzLabs, ADL Canberra ajd@xxxxxxxxxxxxx IBM Australia Limited