Hi Xiu, Thank you for cleaning up the code. The purpose of this patch is to remove code duplication. Perhaps rename the patch to "evm: call dump_security_xattr() in all cases to remove code duplication". On Mon, 2022-12-26 at 18:24 +0800, Xiu Jianfeng wrote: > Currently the debug function of dumping xattr is splited into two parts, > when the length of xattr is less than 64 bytes, it uses pr_debug() > directly. Merge it into dump_security_xattr() to simplify the code, no > functional changes here. > > Signed-off-by: Xiu Jianfeng <xiujianfeng@xxxxxxxxxx> Please reword the patch description in terms of removing code duplication. -- thanks, Mimi