On Sun, Dec 11, 2022 at 10:13:12PM -0500, James Bottomley wrote: > On Mon, 2022-12-12 at 00:50 +0000, Jarkko Sakkinen wrote: > > On Fri, Dec 09, 2022 at 11:06:03AM -0500, James Bottomley wrote: > > > It's very convenient when parsing responses to have a cursor you > > > simply move over the response extracting the data. Add such cursor > > > functions for the TPM unsigned integer types. > > > > > > Signed-off-by: James Bottomley > > > <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > > > > Saying that something is convenient is not really an argument. > > > > What you are going to use it for? Is it complex enough that what we > > have not doesn't scale. I'd just answer these questions and write > > more reasonable commit message. > > It's all used int patch 6 which gets into the complex building of > authenticated and hmac'd requests and responses via sessions using > these primitives. Again state obvious, even if you think it is obvious. It is really useful to have that kind of that as refresher in the commit log. I'm setting rpi 3b + tpm2 chip gpio to try this out. I thought it would be a cool test sytem because later on I can test both fTPM in TZ and SPI dTPM with it... BR, Jarkko
