Hi James, https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/James-Bottomley/add-integrity-and-security-to-TPM2-transactions/20221210-001335 patch link: https://lore.kernel.org/r/20221209160611.30207-7-James.Bottomley%40HansenPartnership.com patch subject: [PATCH 06/11] tpm: Add full HMAC and encrypt/decrypt session handling code config: x86_64-randconfig-m001 compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <error27@xxxxxxxxx> New smatch warnings: drivers/char/tpm/tpm2-sessions.c:294 tpm_buf_append_salt() warn: possible memory leak of 'secret' drivers/char/tpm/tpm2-sessions.c:890 tpm2_start_auth_session() warn: possible memory leak of 'auth' Old smatch warnings: drivers/char/tpm/tpm2-sessions.c:331 tpm_buf_append_salt() warn: possible memory leak of 'secret' vim +/secret +294 drivers/char/tpm/tpm2-sessions.c af8e86ceddca73 James Bottomley 2022-12-09 258 static void tpm_buf_append_salt(struct tpm_buf *buf, struct tpm_chip *chip, af8e86ceddca73 James Bottomley 2022-12-09 259 struct tpm2_auth *auth) af8e86ceddca73 James Bottomley 2022-12-09 260 { af8e86ceddca73 James Bottomley 2022-12-09 261 struct crypto_kpp *kpp; af8e86ceddca73 James Bottomley 2022-12-09 262 struct kpp_request *req; af8e86ceddca73 James Bottomley 2022-12-09 263 struct scatterlist s[2], d[1]; af8e86ceddca73 James Bottomley 2022-12-09 264 struct ecdh p = {0}; af8e86ceddca73 James Bottomley 2022-12-09 265 u8 encoded_key[EC_PT_SZ], *x, *y; af8e86ceddca73 James Bottomley 2022-12-09 266 unsigned int buf_len; af8e86ceddca73 James Bottomley 2022-12-09 267 u8 *secret; af8e86ceddca73 James Bottomley 2022-12-09 268 af8e86ceddca73 James Bottomley 2022-12-09 269 secret = kmalloc(EC_PT_SZ, GFP_KERNEL); af8e86ceddca73 James Bottomley 2022-12-09 270 if (!secret) af8e86ceddca73 James Bottomley 2022-12-09 271 return; af8e86ceddca73 James Bottomley 2022-12-09 272 af8e86ceddca73 James Bottomley 2022-12-09 273 /* secret is two sized points */ af8e86ceddca73 James Bottomley 2022-12-09 274 tpm_buf_append_u16(buf, (EC_PT_SZ + 2)*2); af8e86ceddca73 James Bottomley 2022-12-09 275 /* af8e86ceddca73 James Bottomley 2022-12-09 276 * we cheat here and append uninitialized data to form af8e86ceddca73 James Bottomley 2022-12-09 277 * the points. All we care about is getting the two af8e86ceddca73 James Bottomley 2022-12-09 278 * co-ordinate pointers, which will be used to overwrite af8e86ceddca73 James Bottomley 2022-12-09 279 * the uninitialized data af8e86ceddca73 James Bottomley 2022-12-09 280 */ af8e86ceddca73 James Bottomley 2022-12-09 281 tpm_buf_append_u16(buf, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 282 x = &buf->data[tpm_buf_length(buf)]; af8e86ceddca73 James Bottomley 2022-12-09 283 tpm_buf_append(buf, encoded_key, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 284 tpm_buf_append_u16(buf, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 285 y = &buf->data[tpm_buf_length(buf)]; af8e86ceddca73 James Bottomley 2022-12-09 286 tpm_buf_append(buf, encoded_key, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 287 sg_init_table(s, 2); af8e86ceddca73 James Bottomley 2022-12-09 288 sg_set_buf(&s[0], x, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 289 sg_set_buf(&s[1], y, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 290 af8e86ceddca73 James Bottomley 2022-12-09 291 kpp = crypto_alloc_kpp("ecdh-nist-p256", CRYPTO_ALG_INTERNAL, 0); af8e86ceddca73 James Bottomley 2022-12-09 292 if (IS_ERR(kpp)) { af8e86ceddca73 James Bottomley 2022-12-09 293 dev_err(&chip->dev, "crypto ecdh allocation failed\n"); af8e86ceddca73 James Bottomley 2022-12-09 @294 return; kfree(secret); af8e86ceddca73 James Bottomley 2022-12-09 295 } af8e86ceddca73 James Bottomley 2022-12-09 296 af8e86ceddca73 James Bottomley 2022-12-09 297 buf_len = crypto_ecdh_key_len(&p); af8e86ceddca73 James Bottomley 2022-12-09 298 if (sizeof(encoded_key) < buf_len) { af8e86ceddca73 James Bottomley 2022-12-09 299 dev_err(&chip->dev, "salt buffer too small needs %d\n", af8e86ceddca73 James Bottomley 2022-12-09 300 buf_len); af8e86ceddca73 James Bottomley 2022-12-09 301 goto out; af8e86ceddca73 James Bottomley 2022-12-09 302 } af8e86ceddca73 James Bottomley 2022-12-09 303 crypto_ecdh_encode_key(encoded_key, buf_len, &p); af8e86ceddca73 James Bottomley 2022-12-09 304 /* this generates a random private key */ af8e86ceddca73 James Bottomley 2022-12-09 305 crypto_kpp_set_secret(kpp, encoded_key, buf_len); af8e86ceddca73 James Bottomley 2022-12-09 306 af8e86ceddca73 James Bottomley 2022-12-09 307 /* salt is now the public point of this private key */ af8e86ceddca73 James Bottomley 2022-12-09 308 req = kpp_request_alloc(kpp, GFP_KERNEL); af8e86ceddca73 James Bottomley 2022-12-09 309 if (!req) af8e86ceddca73 James Bottomley 2022-12-09 310 goto out; af8e86ceddca73 James Bottomley 2022-12-09 311 kpp_request_set_input(req, NULL, 0); af8e86ceddca73 James Bottomley 2022-12-09 312 kpp_request_set_output(req, s, EC_PT_SZ*2); af8e86ceddca73 James Bottomley 2022-12-09 313 crypto_kpp_generate_public_key(req); af8e86ceddca73 James Bottomley 2022-12-09 314 /* af8e86ceddca73 James Bottomley 2022-12-09 315 * we're not done: now we have to compute the shared secret af8e86ceddca73 James Bottomley 2022-12-09 316 * which is our private key multiplied by the tpm_key public af8e86ceddca73 James Bottomley 2022-12-09 317 * point, we actually only take the x point and discard the y af8e86ceddca73 James Bottomley 2022-12-09 318 * point and feed it through KDFe to get the final secret salt af8e86ceddca73 James Bottomley 2022-12-09 319 */ af8e86ceddca73 James Bottomley 2022-12-09 320 sg_set_buf(&s[0], chip->ec_point_x, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 321 sg_set_buf(&s[1], chip->ec_point_y, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 322 kpp_request_set_input(req, s, EC_PT_SZ*2); af8e86ceddca73 James Bottomley 2022-12-09 323 sg_init_one(d, secret, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 324 kpp_request_set_output(req, d, EC_PT_SZ); af8e86ceddca73 James Bottomley 2022-12-09 325 crypto_kpp_compute_shared_secret(req); af8e86ceddca73 James Bottomley 2022-12-09 326 kpp_request_free(req); af8e86ceddca73 James Bottomley 2022-12-09 327 af8e86ceddca73 James Bottomley 2022-12-09 328 /* pass the shared secret through KDFe for salt */ af8e86ceddca73 James Bottomley 2022-12-09 329 KDFe(secret, "SECRET", x, chip->ec_point_x, auth->salt); af8e86ceddca73 James Bottomley 2022-12-09 330 out: af8e86ceddca73 James Bottomley 2022-12-09 331 crypto_free_kpp(kpp); af8e86ceddca73 James Bottomley 2022-12-09 332 } -- 0-DAY CI Kernel Test Service https://01.org/lkp
