Hi Huaxin,
Thank you for the patch.
On Sun, 2022-10-16 at 20:20 +0800, luhuaxin1@xxxxxxxxxx wrote:
> From: Huaxin Lu <luhuaxin1@xxxxxxxxxx>
>
> In restore_template_fmt, when kstrdup fails, a non-NULL value will still
> be returned, which causes a NULL pointer access in template_desc_init_fields.
>
> Co-authored-by: Jiaming Li <lijiaming30@xxxxxxxxxx>
> Signed-off-by: Huaxin Lu <luhuaxin1@xxxxxxxxxx>
scripts/checkpatch.pl complains:
- The "Subject:" line being too long. Refer to "summary phrase" in
Documentation/process/submitting-patches.rst.
- Instead of "Co-authored-by" submitting-patches suggests "Co-
developed-by".
In addition, the patch author and your mailer need to be sync. Please
fix your mailer so that the "From:" line is unnecessary.
Otherwise,
Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>
> ---
> security/integrity/ima/ima_template.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/security/integrity/ima/ima_template.c b/security/integrity/ima/ima_template.c
> index 07398f5..f81d4b2 100644
> --- a/security/integrity/ima/ima_template.c
> +++ b/security/integrity/ima/ima_template.c
> @@ -295,8 +295,11 @@ static struct ima_template_desc *restore_template_fmt(char *template_name)
>
> template_desc->name = "";
> template_desc->fmt = kstrdup(template_name, GFP_KERNEL);
> - if (!template_desc->fmt)
> + if (!template_desc->fmt) {
> + kfree(template_desc);
> + template_desc = NULL;
> goto out;
> + }
>
> spin_lock(&template_list);
> list_add_tail_rcu(&template_desc->list, &defined_templates);
