On Fri, 30 Sept 2022 at 14:44, Rob Herring <robh@xxxxxxxxxx> wrote: > > On Wed, Sep 28, 2022 at 02:09:57PM +0930, Joel Stanley wrote: > > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface. > > > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/ > > > > Add a compatible string for it, and the generic compatible. > > > > Signed-off-by: Joel Stanley <joel@xxxxxxxxx> > > --- > > drivers/char/tpm/tpm_tis_i2c.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/char/tpm/tpm_tis_i2c.c b/drivers/char/tpm/tpm_tis_i2c.c > > index 0692510dfcab..4af27b7ec5b1 100644 > > --- a/drivers/char/tpm/tpm_tis_i2c.c > > +++ b/drivers/char/tpm/tpm_tis_i2c.c > > @@ -368,6 +368,8 @@ MODULE_DEVICE_TABLE(i2c, tpm_tis_i2c_id); > > #ifdef CONFIG_OF > > static const struct of_device_id of_tis_i2c_match[] = { > > { .compatible = "infineon,slb9673", }, > > + { .compatible = "nuvoton,npct75x", }, > > + { .compatible = "tcg,tpm-tis-i2c", }, > > If there is not currently any distinction that the kernel makes, you > only need to add "tcg,tpm-tis-i2c". There are device trees that just have one or the other, so it makes sense to list both. > > > {} > > }; > > MODULE_DEVICE_TABLE(of, of_tis_i2c_match); > > -- > > 2.35.1 > > > >