On Fri, Sep 30, 2022 at 11:44:21PM +0300, Jarkko Sakkinen wrote: > On Sun, Sep 25, 2022 at 10:39:58PM -0700, Dmitry Torokhov wrote: > > Driver core will never call driver's probe method without appropriate > > device structure, so testing them for NULL is pointless. > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > Missing a description what the patch does. > > Also instead of "driver's probe method" you could just use > "st33zp24_i2c_probe()". It's even shorter. There are 2 interfaces: I2C and SPI, thus 2 separate probe methods. Thanks. -- Dmitry
