On Sun, Sep 25, 2022 at 10:39:57PM -0700, Dmitry Torokhov wrote: > This patch switches the driver from legacy gpio API to the newer gpiod > API, so that eventually we can drop the former. Once a patch is applied, it's a commit, not a patch. Just start by "Switch ...". Please also define what is the legacy API exactly, and what sort of API it is switched to with a bit more detail. I don't follow GPIO. > During conversion it was noted that the gpio handling code for SPI and > I2C variants duplicates each other, so it was moved into the core. Who noted what? Please provide a reference. I do not connect this sentence to anything, as I do not follow gpio's mailing list. > Also, it seems that the driver never assigned tpm_dev->io_lpcpd in the > past, so gpio-based power management was most likely not working ever. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> BR, Jarkko
