On Wed, May 11, 2022 at 09:29:57PM +0200, Lino Sanfilippo wrote: > > > On 11.05.22 at 13:27, Jarkko Sakkinen wrote: > > On Mon, May 09, 2022 at 10:05:55AM +0200, Lino Sanfilippo wrote: > >> From: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx> > >> > >> It is not necessary to claim and release the default locality for each TPM > >> command. Instead claim the locality once at driver startup and release it > >> at driver shutdown. > >> > >> Signed-off-by: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx> > > > > We are doing what we're being because of Intel TXT: > > > > https://lore.kernel.org/tpmdd-devel/20170315055738.11088-1-jarkko.sakkinen@xxxxxx/ > > > > Unfortunately cannot accept this change. > > > > I do not see how the patch affects the crb code since the only changes concern the > tpm_class_ops of the tis core. AFAICS crb uses its own set of tpm_class_ops > which are still used to claim and release the locality. > > Or do I miss something? Ugh, yes breaking everything when TXT is used with tpm_tis. > Regards, > Lino BR, Jarkko
