Hi Casey, I love your patch! Yet something to improve: [auto build test ERROR on pcmoore-selinux/next] [also build test ERROR on linus/master v5.18-rc3 next-20220414] [cannot apply to pcmoore-audit/next jmorris-security/next-testing] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220419-000109 base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next config: i386-tinyconfig (https://download.01.org/0day-ci/archive/20220419/202204190104.VspbI376-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.2.0-19) 11.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/2fa01492487f9135e9ea9e59924289cc23a66576 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220419-000109 git checkout 2fa01492487f9135e9ea9e59924289cc23a66576 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash kernel/sched/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/linux/perf_event.h:61, from include/linux/trace_events.h:10, from include/trace/syscall.h:7, from include/linux/syscalls.h:88, from include/linux/syscalls_api.h:1, from kernel/sched/core.c:13: include/linux/security.h: In function 'security_cred_getsecid': >> include/linux/security.h:1147:10: error: 'secid' undeclared (first use in this function) 1147 | *secid = 0; | ^~~~~ include/linux/security.h:1147:10: note: each undeclared identifier is reported only once for each function it appears in kernel/sched/core.c: At top level: kernel/sched/core.c:5235:20: warning: no previous prototype for 'task_sched_runtime' [-Wmissing-prototypes] 5235 | unsigned long long task_sched_runtime(struct task_struct *p) | ^~~~~~~~~~~~~~~~~~ kernel/sched/core.c:9420:13: warning: no previous prototype for 'sched_init_smp' [-Wmissing-prototypes] 9420 | void __init sched_init_smp(void) | ^~~~~~~~~~~~~~ kernel/sched/core.c:9448:13: warning: no previous prototype for 'sched_init' [-Wmissing-prototypes] 9448 | void __init sched_init(void) | ^~~~~~~~~~ -- In file included from include/linux/perf_event.h:61, from include/linux/trace_events.h:10, from include/trace/syscall.h:7, from include/linux/syscalls.h:88, from include/linux/syscalls_api.h:1, from kernel/sched/sched.h:60, from kernel/sched/fair.c:53: include/linux/security.h: In function 'security_cred_getsecid': >> include/linux/security.h:1147:10: error: 'secid' undeclared (first use in this function) 1147 | *secid = 0; | ^~~~~ include/linux/security.h:1147:10: note: each undeclared identifier is reported only once for each function it appears in kernel/sched/fair.c: At top level: kernel/sched/fair.c:5530:6: warning: no previous prototype for 'init_cfs_bandwidth' [-Wmissing-prototypes] 5530 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {} | ^~~~~~~~~~~~~~~~~~ kernel/sched/fair.c:11757:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes] 11757 | void free_fair_sched_group(struct task_group *tg) { } | ^~~~~~~~~~~~~~~~~~~~~ kernel/sched/fair.c:11759:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes] 11759 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent) | ^~~~~~~~~~~~~~~~~~~~~~ kernel/sched/fair.c:11764:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes] 11764 | void online_fair_sched_group(struct task_group *tg) { } | ^~~~~~~~~~~~~~~~~~~~~~~ kernel/sched/fair.c:11766:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes] 11766 | void unregister_fair_sched_group(struct task_group *tg) { } | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from include/linux/perf_event.h:61, from include/linux/trace_events.h:10, from include/trace/syscall.h:7, from include/linux/syscalls.h:88, from include/linux/syscalls_api.h:1, from kernel/sched/sched.h:60, from kernel/sched/build_policy.c:33: include/linux/security.h: In function 'security_cred_getsecid': >> include/linux/security.h:1147:10: error: 'secid' undeclared (first use in this function) 1147 | *secid = 0; | ^~~~~ include/linux/security.h:1147:10: note: each undeclared identifier is reported only once for each function it appears in In file included from kernel/sched/build_policy.c:43: kernel/sched/rt.c: At top level: kernel/sched/rt.c:259:6: warning: no previous prototype for 'unregister_rt_sched_group' [-Wmissing-prototypes] 259 | void unregister_rt_sched_group(struct task_group *tg) { } | ^~~~~~~~~~~~~~~~~~~~~~~~~ kernel/sched/rt.c:261:6: warning: no previous prototype for 'free_rt_sched_group' [-Wmissing-prototypes] 261 | void free_rt_sched_group(struct task_group *tg) { } | ^~~~~~~~~~~~~~~~~~~ kernel/sched/rt.c:263:5: warning: no previous prototype for 'alloc_rt_sched_group' [-Wmissing-prototypes] 263 | int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent) | ^~~~~~~~~~~~~~~~~~~~ kernel/sched/rt.c:666:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes] 666 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ -- In file included from kernel/sched/build_utility.c:39: include/linux/security.h: In function 'security_cred_getsecid': >> include/linux/security.h:1147:10: error: 'secid' undeclared (first use in this function) 1147 | *secid = 0; | ^~~~~ include/linux/security.h:1147:10: note: each undeclared identifier is reported only once for each function it appears in vim +/secid +1147 include/linux/security.h ee18d64c1f6320 David Howells 2009-09-02 1143 2fa01492487f91 Casey Schaufler 2022-04-18 1144 static inline void security_cred_getsecid(const struct cred *c, 2fa01492487f91 Casey Schaufler 2022-04-18 1145 struct lsmblob *blob) 4d5b5539742d25 Todd Kjos 2021-10-12 1146 { 4d5b5539742d25 Todd Kjos 2021-10-12 @1147 *secid = 0; 4d5b5539742d25 Todd Kjos 2021-10-12 1148 } 4d5b5539742d25 Todd Kjos 2021-10-12 1149 -- 0-DAY CI Kernel Test Service https://01.org/lkp
