Dear Johannes,
Thank you for the patch.
Am 22.03.22 um 11:59 schrieb Johannes Holland:
Remove unused variables and type mismatch (integer from pointer without
a cast).
Maybe also paste the compiler error message?
As it’s a regression, please also add a Fixes line.
Kind regards,
Paul
Signed-off-by: Johannes Holland <johannes.holland@xxxxxxxxxxxx>
---
drivers/char/tpm/tpm_tis_synquacer.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_synquacer.c b/drivers/char/tpm/tpm_tis_synquacer.c
index 2751be8e6065..679196c61401 100644
--- a/drivers/char/tpm/tpm_tis_synquacer.c
+++ b/drivers/char/tpm/tpm_tis_synquacer.c
@@ -39,11 +39,6 @@ static int tpm_tis_synquacer_read_bytes(struct tpm_tis_data *data, u32 addr,
enum tpm_tis_io_mode io_mode)
{
struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data);
- __le16 result_le16;
- __le32 result_le32;
- u16 result16;
- u32 result32;
-
switch (io_mode) {
case TPM_TIS_PHYS_8:
while (len--)
@@ -69,11 +64,6 @@ static int tpm_tis_synquacer_write_bytes(struct tpm_tis_data *data, u32 addr,
enum tpm_tis_io_mode io_mode)
{
struct tpm_tis_synquacer_phy *phy = to_tpm_tis_tcg_phy(data);
- __le16 result_le16;
- __le32 result_le32;
- u16 result16;
- u32 result32;
-
switch (io_mode) {
case TPM_TIS_PHYS_8:
while (len--)
@@ -86,10 +76,10 @@ static int tpm_tis_synquacer_write_bytes(struct tpm_tis_data *data, u32 addr,
* Due to the limitation of SPI controller on SynQuacer,
* 16/32 bits access must be done in byte-wise and descending order.
*/
- iowrite8(&value[3], phy->iobase + addr + 3);
- iowrite8(&value[2], phy->iobase + addr + 2);
- iowrite8(&value[1], phy->iobase + addr + 1);
- iowrite8(&value[0], phy->iobase + addr);
+ iowrite8(value[3], phy->iobase + addr + 3);
+ iowrite8(value[2], phy->iobase + addr + 2);
+ iowrite8(value[1], phy->iobase + addr + 1);
+ iowrite8(value[0], phy->iobase + addr);
break;
}
