On Tue, Jan 11, 2022 at 04:25:09AM +0200, Jarkko Sakkinen wrote: > On Mon, Jan 10, 2022 at 11:12:41AM -0500, Nayna wrote: > > > > On 1/8/22 08:54, Jarkko Sakkinen wrote: > > > On Wed, Jan 05, 2022 at 12:54:08PM -0500, Nayna Jain wrote: > > > > load_certificate_list() parses certificates embedded in the kernel > > > > image to load them onto the keyring. > > > > > > > > Commit "2565ca7f5ec1 (certs: Move load_system_certificate_list to a common > > > > function)" made load_certificate_list() a common function in the certs/ > > > > directory. Now, export load_certificate_list() outside certs/ to be used > > > > by load_platform_certificate_list() which is added later in the patchset. > > > > > > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> (auto build test ERROR) > > > > Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx> > > > > Signed-off-by: Nayna Jain <nayna@xxxxxxxxxxxxx> > > > This lacking fixes tag, if it is a bug, or "reported-by" needs to be > > > completely removed. > > > > When I posted my first version for this patch set, kernel test robot > > reported the build error - > > https://lore.kernel.org/linux-integrity/202109110507.ucpEmrwz-lkp@xxxxxxxxx/ > > > > The Reported-by tag is because of this statement in the reported error - " > > If you fix the issue, kindly add following tag as appropriate Reported-by: > > kernel test robot <lkp@xxxxxxxxx>" > > > > Do you still think that the tag is not required ? If so, I am fine to remove > > it. > > It makes absolutely no sense for anything that is not triggered by the > mainline code. I.e. if it is not merged, there is no bug. /Jarkko
