> On Nov 18, 2021, at 5:20 PM, Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote:
>
> Hi Eric,
>
> On Mon, 2021-11-15 at 19:15 -0500, Eric Snowberg wrote:
>> Introduce a new link restriction that includes the trusted builtin,
>> secondary and machine keys. The restriction is based on the key to be
>> added being vouched for by a key in any of these three keyrings.
>>
>> Suggested-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>
>> Signed-off-by: Eric Snowberg <eric.snowberg@xxxxxxxxxx>
>> ---
>> v3: Initial version
>> v4: moved code under CONFIG_INTEGRITY_MOK_KEYRING
>> v5: Rename to machine keyring
>> v6: Change subject name (suggested by Mimi)
>> Rename restrict_link_by_builtin_secondary_and_ca_trusted
>> to restrict_link_by_builtin_secondary_and_machine (suggested by
>> Mimi)
>> v7: Unmodified from v6
>> ---
>> certs/system_keyring.c | 23 +++++++++++++++++++++++
>> include/keys/system_keyring.h | 6 ++++++
>> 2 files changed, 29 insertions(+)
>>
>> diff --git a/certs/system_keyring.c b/certs/system_keyring.c
>> index bc7e44fc82c2..71a00add9805 100644
>> --- a/certs/system_keyring.c
>> +++ b/certs/system_keyring.c
>> @@ -99,6 +99,29 @@ void __init set_machine_trusted_keys(struct key *keyring)
>> {
>> machine_trusted_keys = keyring;
>> }
>> +
>> +/**
>
> This begins the start of kernel doc.
>
>> + * restrict_link_by_builtin_secondary_and_machine
>
> Missing are the parameter defintions. Please refer to
> Documentation/doc-guide/kernel-doc.rst for details.
I’ll add this in the next round, thanks.
