On Thu, 2021-11-04 at 16:02 +0200, amirmizi6@xxxxxxxxx wrote:
> From: Amir Mizinski <amirmizi6@xxxxxxxxx>
>
> tpm_tis_req_canceled() function is used to check if the caller requested
> to abort the current operation. It was found that in some cases
> tpm_tis_req_canceled() wrongly returned true.
Please, bring some context, i.e. please describe the scenarios.
> Since a cancel request sets the TPM_STS.commandReady field to TRUE, the
~~~~~~~~~~~~~~
What the heck is this? Please refer the exact things.
> tpm_tis_req_canceled() function should check only the TPM_STS.commandReady
> field value.
Why?
> The case for TPM_VID_WINBOND is wrong and was therefore removed.
Why?
It is not removed in the existing mainline, so it definitely *was not*
removed.
> Also, the default comparison is wrong. Only cmdReady bit needs to be
> compared instead of the full lower status register byte.
You should split this into two patches, if it fixes two different
issues.
/Jarkko
