Re: [PATCH v6 05/13] integrity: add new keyring handler for mok keys

[kernel test robot <lkp@xxxxxxxxx>]

Hi Eric,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f]

url:    https://github.com/0day-ci/linux/commits/Eric-Snowberg/Enroll-kernel-keys-thru-MOK/20210915-051742
base:   6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/18c80634d92ba6ecc8e3a7d0b2dd793b586fc828
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eric-Snowberg/Enroll-kernel-keys-thru-MOK/20210915-051742
        git checkout 18c80634d92ba6ecc8e3a7d0b2dd793b586fc828
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   security/integrity/platform_certs/keyring_handler.c:71:30: error: no previous prototype for 'get_handler_for_db' [-Werror=missing-prototypes]
      71 | __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
         |                              ^~~~~~~~~~~~~~~~~~
>> security/integrity/platform_certs/keyring_handler.c:82:30: error: no previous prototype for 'get_handler_for_mok' [-Werror=missing-prototypes]
      82 | __init efi_element_handler_t get_handler_for_mok(const efi_guid_t *sig_type)
         |                              ^~~~~~~~~~~~~~~~~~~
   security/integrity/platform_certs/keyring_handler.c:97:30: error: no previous prototype for 'get_handler_for_dbx' [-Werror=missing-prototypes]
      97 | __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type)
         |                              ^~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/get_handler_for_mok +82 security/integrity/platform_certs/keyring_handler.c

    66	
    67	/*
    68	 * Return the appropriate handler for particular signature list types found in
    69	 * the UEFI db tables.
    70	 */
  > 71	__init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
    72	{
    73		if (efi_guidcmp(*sig_type, efi_cert_x509_guid) == 0)
    74			return add_to_platform_keyring;
    75		return 0;
    76	}
    77	
    78	/*
    79	 * Return the appropriate handler for particular signature list types found in
    80	 * the MokListRT tables.
    81	 */
  > 82	__init efi_element_handler_t get_handler_for_mok(const efi_guid_t *sig_type)
    83	{
    84		if (efi_guidcmp(*sig_type, efi_cert_x509_guid) == 0) {
    85			if (IS_ENABLED(CONFIG_INTEGRITY_MACHINE_KEYRING))
    86				return add_to_machine_keyring;
    87			else
    88				return add_to_platform_keyring;
    89		}
    90		return 0;
    91	}
    92	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip