On 29.07.21 07:56, Sumit Garg wrote: > Hi Eric, > > On Wed, 28 Jul 2021 at 21:35, Eric Biggers <ebiggers@xxxxxxxxxx> wrote: >> >> On Wed, Jul 28, 2021 at 10:50:42AM +0200, Ahmad Fatoum wrote: >>> Hello Eric, >>> >>> On 27.07.21 18:38, Eric Biggers wrote: >>>> On Tue, Jul 27, 2021 at 04:43:49PM +0200, Ahmad Fatoum wrote: >>>>> For both v1 and v2 key setup mechanisms, userspace supplies the raw key >>>>> material to the kernel after which it is never again disclosed to >>>>> userspace. >>>>> >>>>> Use of encrypted and trusted keys offers stronger guarantees: >>>>> The key material is generated within the kernel and is never disclosed to >>>>> userspace in clear text and, in the case of trusted keys, can be >>>>> directly rooted to a trust source like a TPM chip. >>>> >>>> Please include a proper justification for this feature >>> >>> I've patches pending for extending trusted keys to wrap the key sealing >>> functionality of the CAAM IP on NXP SoCs[1]. I want the kernel to >>> generate key material in the factory, have the CAAM encrypt it using its >>> undisclosed unique key and pass it to userspace as encrypted blob that is >>> persisted to an unencrypted volume. The intention is to thwart offline >>> decryption of an encrypted file system in an embedded system, where a >>> passphrase can't be supplied by an end user. >>> >>> Employing TPM and TEE trusted keys with this is already possible with >>> dm-crypt, but I'd like this to be possible out-of-the-box with >>> ubifs + fscrypt as well. >> >> Why not do the key management in userspace, like tpm-tools >> (https://github.com/tpm2-software/tpm2-tools)? There are a lot of uses for this >> type of hardware besides in-kernel crypto. See >> https://wiki.archlinux.org/title/Trusted_Platform_Module for all the things you >> can do with the TPM on Linux, including LUKS encryption; this is all with >> userspace key management. Wouldn't the CAAM hardware be useful for similar >> purposes and thus need a similar design as well, e.g. with functionality exposed >> through some /dev node for userspace to use? Or are you saying it will only >> ever be useful for in-kernel crypto? > > AFAIK from my prior experience while working with CAAM engine during > my time at NXP, it is generally a crypto engine with additional > security properties like one discussed here to protect keys (blob > encap and decap) etc. But it doesn't offer user authentication similar > to what a TPM (ownership) can offer. Although, one should be able to > expose CAAM via /dev node but I am not sure if that would be really > useful without user authentication. I think similar should be the case > for other crypto engines with additional security properties. > > With restriction of CAAM's security properties to kernel crypto we > could at least ensure a kernel boundary that should offer enough > resistance from malicious user space attacks. Which are a real possibility given the CAAM's direct memory access. We now have safe interfaces mainline wrapping it for HWRNG, crypto acceleration and hopefully soon key sealing and I don't think throwing existing kernel driver support away and inventing a new CAAM uAPI is a practical alternative. >>>> Note that there are several design flaws with the encrypted and trusted key >>>> types: >>>> >>>> - By default, trusted keys are generated using the TPM's RNG rather than the >>>> kernel's RNG, which places all trust in an unauditable black box. >>> > > With regards to trusted keys generated using the TEE's RNG, the > underlying implementation being OP-TEE [1] which is an open source TEE > implementation built on top of Arm TrustZone providing the hardware > based isolation among the TEE and Linux. So regarding auditability, it > should be comparatively easier to audit the TEE components designed > with a goal of minimal footprint when compared with Linux kernel. > > [1] https://github.com/OP-TEE/optee_os > >>> Patch to fix that awaits feedback on linux-integrity[2]. >> >> It does *not* fix it, as your patch only provides an option to use the kernel's >> RNG whereas the default is still the TPM's RNG. >> > > Yes in case of TPM, default is still TPM's RNG but with Ahmad's patch > #2, the trust source backend like CAAM should be able to use kernel's > RNG by default. Exactly. >> Most people don't change defaults. >> >> Essentially your same argument was used for Dual_EC_DRBG; people argued it was >> okay to standardize because people had the option to choose their own constants >> if they felt the default constants were backdoored. That didn't really matter, >> though, since in practice everyone just used the default constants. I'd appreciate your feedback on my CAAM series if you think the defaults can be improved. Trusted keys are no longer restricted to TPMs, so users of other backends shouldn't be dismissed, because one backend can be used with fscrypt by alternative means. >>>> - trusted and encrypted keys aren't restricted to specific uses in the kernel >>>> (like the fscrypt-provisioning key type is) but rather are general-purpose. >>>> Hence, it may be possible to leak their contents to userspace by requesting >>>> their use for certain algorithms/features, e.g. to encrypt a dm-crypt target >>>> using a weak cipher that is vulnerable to key recovery attacks. >>> >>> The footgun is already there by allowing users to specify their own >>> >>> raw key. Users can already use $keyid for dm-crypt and then do >>> >>> $ keyctl pipe $keyid | fscryptctl add_key /mnt >>> >>> The responsibility to not reuse key material already lies with the users, >>> regardless if they handle the raw key material directly or indirectly via >>> a trusted key description/ID. >> >> Elsewhere you are claiming that "trusted" keys can never be disclosed to >> userspace. So you can't rely on userspace cooperating, right? The users I meant are humans, e.g. system integrators. They need to think about burning fuses, signing bootloaders, verifying kernel and root file systems, encrypting file systems and safekeeping their crypto keys. Ample opportunity for stuff to go wrong. They would benefit from having relevant kernel functionality integrate with each other instead of having to carry downstream patches, which we and many others[1] did for years. We now finally have a chance to drop this technical debt thanks to Sumit's trusted key rework and improve user security along the way. So, Eric, how should we proceed? [1]: See the CAAM series cover letter for a history of CAAM sealing upstreaming efforts Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
