Hi Roberto, On Mon, 2021-07-05 at 11:09 +0200, Roberto Sassu wrote: > This patch adds the 'digest' and 'digest_len' parameters to > ima_measure_critical_data() and process_buffer_measurement(), so that > callers can get the digest of the passed buffer. > > These functions calculate the digest even if there is no suitable rule in > the IMA policy and, in this case, they simply return 1 before generating a > new measurement entry. I agree ima_measure_critical_data() is special. Both this patch description and 1/3 describe "what", not "why". Please provide the motivation for these changes at least in the cover letter, if not in the patch description. thanks, Mimi