Re: [PATCH ima-evm-utils] Fix NULL pointer warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/13/2021 12:24 PM, Mimi Zohar wrote:
Static analysis reported an "invalid operation involving NULL pointer"
warning.  Although the code properly exits the loop without ever
using the variable, test the pointer isn't NULL before incrementing
it.

Fixes: 80d3fda6083f ("ima-evm-utils: Check for tsspcrread in runtime")
Signed-off-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>
---
  src/utils.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Lakshmi Ramasubramanian <nramas@xxxxxxxxxxxxxxxxxxx>

 -lakshmi


diff --git a/src/utils.c b/src/utils.c
index ce2cc285a930..fd9b4a84189f 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -77,7 +77,8 @@ int get_cmd_path(const char *prog_name, char *buf, size_t buf_len)
  		if (buf_len - size > ret && file_exist(buf))
  			return 0;
- start = end + 1;
+		if (end != NULL)
+			start = end + 1;
} while (end != NULL);



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux Kernel]     [Linux Kernel Hardening]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux