Mimi,
On Mon, Jul 12, 2021 at 04:04:29PM -0400, Mimi Zohar wrote:
> On Mon, 2021-07-12 at 08:44 +0300, Vitaly Chikunov wrote:
> > Allow user to set signature's keyid using `--keyid' option. Keyid should
> > correspond to SKID in certificate. When keyid is calculated using SHA-1
> > in libimaevm it may mismatch keyid extracted by the kernel from SKID of
> > certificate (the way public key is presented to the kernel), thus making
> > signatures not verifiable. This may happen when certificate is using non
> > SHA-1 SKID (see rfc7093) or just 'unique number' (see rfc5280 4.2.1.2).
> > As a last resort user may specify arbitrary keyid using the new option.
> > Certificate filename could be used instead of the hex number with
> > `--keyid-from-cert' option. And, third option is to read keyid from the
> > cert appended to the key file.
> >
> > These commits create backward incompatible ABI change for libimaevm,
> > thus soname should be incremented on release.
>
> I can't seem to apply either of your patch sets using "git am", only
> manually using "patch -p0 < <mbox>". This hasn't been a problem in
> the past. Did you do something differently?
Ah. I sent from the different box where git configured with:
[diff]
noprefix = true
Sorry. Will resend later.
>
> thanks,
>
> Mimi
