On Mon, Jun 28, 2021 at 10:34:26AM -0700, Linus Torvalds wrote: > On Wed, Jun 23, 2021 at 6:56 AM Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote: > > > > Contains bug fixes for TPM, and support for signing modules using elliptic > > curve keys, which I promised to pick up to my tree. > > I pulled this, but then I looked at the key type changes, and that > made me so scared that I unpulled it again. > > In particular, that code will do > > shell rm -f $(CONFIG_MODULE_SIG_KEY) > > from the Makefile if some config options have changed. > > That just seems too broken for words. Maybe I misunderstand this, but > this really seems like an easy mistake might cause the kernel build to > actively start removing some random user key files that the user > pointed at previously. > > Linus Since there was still a new fix for the series [*], I'd rather refine the pull request without these patches, and not risk them being blocker for the rest of the commits. [*] https://lore.kernel.org/linux-integrity/20210629201257.dr77kemy66mxpox5@xxxxxxxxxx/ /Jarkko
