On Wed, Jun 23, 2021 at 10:49:27PM -0700, Hao Wu wrote: > > On Jun 23, 2021, at 6:35 AM, Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote: > > > > On Sun, Jun 20, 2021 at 04:18:09PM -0700, Hao Wu wrote: > >> This is a fix for the ATMEL TPM crash bug reported in > >> https://patchwork.kernel.org/project/linux-integrity/patch/20200926223150.109645-1-hao.wu@xxxxxxxxxx/ > >> > >> According to the discussions in the original thread, > >> we don't want to revert the timeout of wait_for_tpm_stat > >> for non-ATMEL chips, which brings back the performance cost. > >> For investigation and analysis of why wait_for_tpm_stat > >> caused the issue, and how the regression was introduced, > >> please read the original thread above. > >> > >> Thus the proposed fix here is to only revert the timeout > >> for ATMEL chips by checking the vendor ID. > >> > >> Test Plan: > >> - Run fixed kernel with ATMEL TPM chips and see crash > >> has been fixed. > >> - Run fixed kernel with non-ATMEL TPM chips, and confirm > >> the timeout has not been changed. > > > > Please move test plan right before diffstat if you wan to include such, > > so that it does not go into the commit log. > Hi Jarkko, not sure I understood your suggestion or not. I removed > the test plan from the commit message in a updated commit > https://patchwork.kernel.org/project/linux-integrity/patch/20210624053321.861-1-hao.wu@xxxxxxxxxx/ > > Let me know if I misunderstood this. I am fine to not include test plan, > If this is not something expected by linux community. > I personally think it is helpful to understand the confidence of the commit. > > > > >> --- You can add it right here. Then it won't be included to the actual commit log but is still available in the patch. /Jarkko
