On Thu, 2021-06-03 at 12:55 -0400, Mimi Zohar wrote:
>
> On Thu, 2021-06-03 at 09:34 -0700, nramas wrote:
> > > +void evm_bin2hex_print(const char *prefix, const void *src,
> > > size_t
> > > count);
> > >
> >
> > For evm_bin2hex_print() can we could do the following in evm.h?
> >
> > #ifdef DEBUG
> > void evm_bin2hex_print(const char *prefix, const void *src, size_t
> > count);
> > #else
> > void evm_bin2hex_print(const char *prefix, const void *src, size_t
> > count) {}
> > #endif /* DEBUG */
>
> Yes, if we decide that it needs to be based on DEBUG, this would be
> the
> proper way of doing it. However, since there's nothing really
> private
> here, it's just displaying the security xattrs and other file
> metadata,
> should enabling/disabling the debugging be runtime
> configurable? Kind
> of like how print_hex_dump() relies on loglevel. Or should it be
> more
> granular?
>
I read "Documentation/admin-guide/dynamic-debug-howto.rst". I think
dynamically enabling/disabling, like how print_hex_dump() does, would
be better for evm_bin2hex_print() as well.
thanks,
-lakshmi
