Hi, On 29.04.21 at 08:58, Jarkko Sakkinen wrote: > > This is a sentence that you should delete: > > "However over SPI those accesses require a sleepable context, since a > mutex is used in the concerning functions. " > > It neither explains anything who and why sort of stuff. > > Why don't you put intead something like > > "Inside tpm_int_handler(), tpm_tis_read32() and tpm_tis_write32() are > invoked. The SPI subsystem requires mutex for I/O, which means that the > calls ought not to be used inside interrupt context." > > (I did not check typos). Generally speaking, commit message is as, if not > more important than the code change. > > /Jarkko > ok, I will rephrase this in the next patch version. Regards, Lino
